Change in osmo-pcu[master]: Add ARQ type helpers

osmith gerrit-no-reply at lists.osmocom.org
Tue Mar 26 15:16:26 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13406 )

Change subject: Add ARQ type helpers
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/13406/3/src/coding_scheme.c
File src/coding_scheme.c:

https://gerrit.osmocom.org/#/c/13406/3/src/coding_scheme.c@177
PS3, Line 177: char *egprs_arq_type_name(const struct gprs_rlcmac_bts *bts)
"const char *"?


https://gerrit.osmocom.org/#/c/13406/3/src/pcu_vty.c
File src/pcu_vty.c:

https://gerrit.osmocom.org/#/c/13406/3/src/pcu_vty.c@222
PS3, Line 222: 	if (egprs_arq_type_2(bts))
Just being curious: what's the advantage of using a function here? The previous statement is shorter and one less function to maintain, so I'm wondering.



-- 
To view, visit https://gerrit.osmocom.org/13406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I844aca7dcd9d7f41e5975c1edd1905951f271998
Gerrit-Change-Number: 13406
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Mar 2019 15:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190326/a222e56b/attachment.html>


More information about the gerrit-log mailing list