Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

osmith gerrit-no-reply at lists.osmocom.org
Tue Mar 26 14:24:58 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13415 )

Change subject: Add osmocom-build-old-tags-against-master.sh
......................................................................


Patch Set 6:

(2 comments)

> I think the entire test should not stop/fail if one particular tag is failing to build. Instead it should be recorded which tag failed (and why) and the test should proceed to check other tags.

Thanks for the input!

It does not stop anymore if a tag fails to build. If the failure is known, it just prints "err" besides the tag name. Otherwise it prints "ERR" and shows a chunk of the new-error-logs at the end and fails the jenkins job.

It looks like this now:
https://jenkins.osmocom.org/jenkins/job/Osmocom-build-tags-against-master/10/console

https://gerrit.osmocom.org/#/c/13415/5//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13415/5//COMMIT_MSG@19
PS5, Line 19: easily.
> Would it be possible to enable them and still run through with the rest of the test?
Done


https://gerrit.osmocom.org/#/c/13415/5/scripts/osmocom-build-old-tags-against-master.sh
File scripts/osmocom-build-old-tags-against-master.sh:

https://gerrit.osmocom.org/#/c/13415/5/scripts/osmocom-build-old-tags-against-master.sh@53
PS5, Line 53: 			echo "1.2.1" # depends on libosmo-legacy-mgcp
> Would be nice to document output format: is it space-separated list of tags?
It is one tag per line. Documented it now on top of the function.



-- 
To view, visit https://gerrit.osmocom.org/13415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cb45cc40c9930840a3d4e6a86f39e1400478ed3
Gerrit-Change-Number: 13415
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Mar 2019 14:24:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190326/8854a3bf/attachment.html>


More information about the gerrit-log mailing list