Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...

dexter gerrit-no-reply at lists.osmocom.org
Tue Mar 26 10:05:03 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/13340 )

Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 3: Code-Review+2

https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py
File pySim/cards.py:

https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py@540
PS2, Line 540: 
> You're overwriting the other sel_ctrl here, is that intended? […]
During my tests it did not break anything.

The 0004 makes the card placing a report of the file properties in the buffer, we can then use a GET RESPONSE command to fetch this data to figure out the file length.

(in the old days of normal SIMs things were much easier, the length was returned by default along with some other parameters, also no TLV parsing was necessary)



-- 
To view, visit https://gerrit.osmocom.org/13340
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Mar 2019 10:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190326/15f530a5/attachment.html>


More information about the gerrit-log mailing list