Change in pysim[master]: commands: correct case of a TLV tag (A5 => a5)

dexter gerrit-no-reply at lists.osmocom.org
Tue Mar 26 08:42:26 UTC 2019


dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13339 )

Change subject: commands: correct case of a TLV tag (A5 => a5)
......................................................................

commands: correct case of a TLV tag (A5 => a5)

The hexadecimal tag defintions of pytlv are case sensitive strings. So
'A5' is something different than 'a5'. Pytlv uses lower case letters for
the upper hexadecimal digits. Lets correct this.

Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0
Related: OS#3850
---
M pySim/commands.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Willmann: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/pySim/commands.py b/pySim/commands.py
index 73c2247..913f394 100644
--- a/pySim/commands.py
+++ b/pySim/commands.py
@@ -35,7 +35,7 @@
 		# see also: ETSI TS 102 221, chapter 11.1.1.3.1 Response for MF,
 		# DF or ADF
                 from pytlv.TLV import TLV
-		tlvparser = TLV(['82', '83', '84', 'A5', '8a', '8b', '8c', '80', 'ab', 'c6', '81', '88'])
+		tlvparser = TLV(['82', '83', '84', 'a5', '8a', '8b', '8c', '80', 'ab', 'c6', '81', '88'])
 
 		# pytlv is case sensitive!
 		fcp = fcp.lower()

-- 
To view, visit https://gerrit.osmocom.org/13339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0
Gerrit-Change-Number: 13339
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190326/3047e33e/attachment.html>


More information about the gerrit-log mailing list