Change in osmo-pcu[master]: bts.h: always include C-headers

Max gerrit-no-reply at lists.osmocom.org
Mon Mar 25 21:24:55 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 )

Change subject: bts.h: always include C-headers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13403/1/src/bts.h
File src/bts.h:

https://gerrit.osmocom.org/#/c/13403/1/src/bts.h@44
PS1, Line 44: #endif
> I'm pointing out how usually C headers are guarded on C++ code

That doesn't seem relevant: the headers below #ifdef __cplusplus in a current patch version are C++ headers which should not be included directly into .c file which use bts.h. Especially if they were not included before this patch. And even more so if the only reason to include them is "that's how it usually looks like".



-- 
To view, visit https://gerrit.osmocom.org/13403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b7dc8e8786671a054af2f1e7d836b863a25e60
Gerrit-Change-Number: 13403
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Mar 2019 21:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190325/43388bbb/attachment.html>


More information about the gerrit-log mailing list