Change in osmo-pcu[master]: bts.h: always include C-headers

Max gerrit-no-reply at lists.osmocom.org
Mon Mar 25 16:44:25 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 )

Change subject: bts.h: always include C-headers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13403/1/src/bts.h
File src/bts.h:

https://gerrit.osmocom.org/#/c/13403/1/src/bts.h@44
PS1, Line 44: #endif
> This endif should go in line 35.
What makes you think that? Even if it won't break the compilation (which I doubt) including cpp headers into c files doesn't seem like a good idea.



-- 
To view, visit https://gerrit.osmocom.org/13403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b7dc8e8786671a054af2f1e7d836b863a25e60
Gerrit-Change-Number: 13403
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Mar 2019 16:44:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190325/7d5e2d14/attachment.html>


More information about the gerrit-log mailing list