Change in openbsc[master]: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Mar 25 15:22:36 UTC 2019


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13387 )

Change subject: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init
......................................................................

talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init

There's already a public API to allocate libosmocore's signal ctx, so
let's use it instead of accessing the global variable. This will allow
to eventually Make the global variable in libosmocore static and
private.

Change-Id: I8dab0ef810adba17fdd242e3a127908dd09b2b42
---
M openbsc/src/libcommon/talloc_ctx.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libcommon/talloc_ctx.c b/openbsc/src/libcommon/talloc_ctx.c
index 5e3d9ae..7164851 100644
--- a/openbsc/src/libcommon/talloc_ctx.c
+++ b/openbsc/src/libcommon/talloc_ctx.c
@@ -19,6 +19,7 @@
 
 #include <osmocom/core/talloc.h>
 #include <osmocom/core/msgb.h>
+#include <osmocom/core/signal.h>
 
 extern void *tall_bsc_ctx;
 extern void *tall_fle_ctx;
@@ -29,7 +30,6 @@
 extern void *tall_sub_req_ctx;
 extern void *tall_call_ctx;
 extern void *tall_paging_ctx;
-extern void *tall_sigh_ctx;
 extern void *tall_tqe_ctx;
 extern void *tall_trans_ctx;
 extern void *tall_map_ctx;
@@ -47,10 +47,10 @@
 	tall_sub_req_ctx = talloc_named_const(ctx_root, 0, "subscr_request");
 	tall_call_ctx = talloc_named_const(ctx_root, 0, "gsm_call");
 	tall_paging_ctx = talloc_named_const(ctx_root, 0, "paging_request");
-	tall_sigh_ctx = talloc_named_const(ctx_root, 0, "signal_handler");
 	tall_tqe_ctx = talloc_named_const(ctx_root, 0, "subch_txq_entry");
 	tall_trans_ctx = talloc_named_const(ctx_root, 0, "transaction");
 	tall_map_ctx = talloc_named_const(ctx_root, 0, "trau_map_entry");
 	tall_upq_ctx = talloc_named_const(ctx_root, 0, "trau_upq_entry");
 	tall_ctr_ctx = talloc_named_const(ctx_root, 0, "counter");
+	osmo_signal_talloc_ctx_init(ctx_root);
 }

-- 
To view, visit https://gerrit.osmocom.org/13387
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dab0ef810adba17fdd242e3a127908dd09b2b42
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190325/419184f7/attachment.html>


More information about the gerrit-log mailing list