Change in libosmocore[master]: Revert "ipa_ccm_idtag_parse*: Fix reported length value"

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 25 14:43:53 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13396 )

Change subject: Revert "ipa_ccm_idtag_parse*: Fix reported length value"
......................................................................

Revert "ipa_ccm_idtag_parse*: Fix reported length value"

This reverts commit 1261db15058cfa94615f26c1083bb8a38d09218b.

The patch broke openbsc's external tests, and currently it is unclear
whether it is just an error in the test or if openbsc makes wrong
assumptions about the length value. Let's revert the patch to unblock
the master-openbsc jenkins job.

Related: OS#3851
Change-Id: I9adea35ff6de36c1611c7f85dde1b15bc1c0e786
---
M src/gsm/ipa.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c
index b6fdc98..d423c26 100644
--- a/src/gsm/ipa.c
+++ b/src/gsm/ipa.c
@@ -128,7 +128,7 @@
 
 		DEBUGPC(DLMI, "%s='%s' ", ipa_ccm_idtag_name(t_tag), cur);
 
-		dec->lv[t_tag].len = t_len - 1 - len_offset;
+		dec->lv[t_tag].len = t_len - len_offset;
 		dec->lv[t_tag].val = cur;
 
 		cur += t_len - len_offset;

-- 
To view, visit https://gerrit.osmocom.org/13396
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9adea35ff6de36c1611c7f85dde1b15bc1c0e786
Gerrit-Change-Number: 13396
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190325/48244ec6/attachment.html>


More information about the gerrit-log mailing list