Change in osmo-pcu[master]: Use libosmocore for IMSI parsing

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Mar 25 07:37:33 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13395 )

Change subject: Use libosmocore for IMSI parsing
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13395/1/src/gprs_bssgp_pcu.cpp
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/#/c/13395/1/src/gprs_bssgp_pcu.cpp@116
PS1, Line 116: 17
Wait, the string buffer is defined as:

  char imsi[16] = "000";

so why its length is 17 and not 16?



-- 
To view, visit https://gerrit.osmocom.org/13395
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1
Gerrit-Change-Number: 13395
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 07:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190325/482fe60f/attachment.html>


More information about the gerrit-log mailing list