Change in osmo-msc[master]: vlr_subscr: use osmo_use_count

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Mar 24 17:16:24 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13136 )

Change subject: vlr_subscr: use osmo_use_count
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/gsm_04_08.c@1804
PS2, Line 1804: "conn"
> no #define here?  See my comment about in-line literal strings vs. […]
I'm more than aware and am surprised to see an insane string literal here. must be some brain lapse during early testing...

ah. now I know why this survived, this "conn" token is refactored away in the MSC-roles split.



-- 
To view, visit https://gerrit.osmocom.org/13136
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib06d030e8464abe415ff597d462ed40eeddef475
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Sun, 24 Mar 2019 17:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190324/98939527/attachment.html>


More information about the gerrit-log mailing list