Change in osmo-pcu[master]: Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Mar 22 20:13:13 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/3384 )

Change subject: Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP
......................................................................


Patch Set 13: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/3384/13/src/pcu_l1_if.cpp
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/#/c/3384/13/src/pcu_l1_if.cpp@615
PS13, Line 615: susp_req->tlli
As far as I can see, tlli is of type uint32_t, and we're using the network byte order on PCU interface. Do we need to use ntohl() here?


https://gerrit.osmocom.org/#/c/3384/13/src/pcu_l1_if.cpp@620
PS13, Line 620: susp_req->tlli,
... and does this function expect the network byte order?



-- 
To view, visit https://gerrit.osmocom.org/3384
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4beb413a6f974373a404b5a11c44d86ba695d3
Gerrit-Change-Number: 3384
Gerrit-PatchSet: 13
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Mar 2019 20:13:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190322/b4a60c4a/attachment.html>


More information about the gerrit-log mailing list