Change in osmo-pcu[master]: Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Mar 22 15:48:59 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/3384 )

Change subject: Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.osmocom.org/#/c/3384/13/src/pcu_l1_if.cpp
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/#/c/3384/13/src/pcu_l1_if.cpp@614
PS13, Line 614: INFO
> Is it worth having this logged as INFO and not DEBUG (like the paging request above)? As I understan […]
I actually think it's exactly the kind of message I would want to see with "INFO".  I think in general we often don't use the full "dynamic range" of our log levels.  Lots of DEBUG, some ERROR, but very few other levels.



-- 
To view, visit https://gerrit.osmocom.org/3384
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4beb413a6f974373a404b5a11c44d86ba695d3
Gerrit-Change-Number: 3384
Gerrit-PatchSet: 13
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Mar 2019 15:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190322/f2d25553/attachment.html>


More information about the gerrit-log mailing list