Change in libosmocore[master]: Revert "signal.c: Make non-exported tall_sigh_ctx static"

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Mar 22 13:59:55 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13385 )

Change subject: Revert "signal.c: Make non-exported tall_sigh_ctx static"
......................................................................


Patch Set 1: Code-Review-1

What about applying this patch in openbsc instead?

diff --git a/openbsc/src/libcommon/talloc_ctx.c b/openbsc/src/libcommon/talloc_ctx.c
index 5e3d9aebe..2cbb76e57 100644
--- a/openbsc/src/libcommon/talloc_ctx.c
+++ b/openbsc/src/libcommon/talloc_ctx.c
@@ -47,10 +47,10 @@ void talloc_ctx_init(void *ctx_root)
        tall_sub_req_ctx = talloc_named_const(ctx_root, 0, "subscr_request");
        tall_call_ctx = talloc_named_const(ctx_root, 0, "gsm_call");
        tall_paging_ctx = talloc_named_const(ctx_root, 0, "paging_request");
-       tall_sigh_ctx = talloc_named_const(ctx_root, 0, "signal_handler");
        tall_tqe_ctx = talloc_named_const(ctx_root, 0, "subch_txq_entry");
        tall_trans_ctx = talloc_named_const(ctx_root, 0, "transaction");
        tall_map_ctx = talloc_named_const(ctx_root, 0, "trau_map_entry");
        tall_upq_ctx = talloc_named_const(ctx_root, 0, "trau_upq_entry");
        tall_ctr_ctx = talloc_named_const(ctx_root, 0, "counter");
+       osmo_signal_talloc_ctx_init(ctx_root);
 }



(+ adding required header, etc.)


-- 
To view, visit https://gerrit.osmocom.org/13385
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4cb31427a1cad063bc9f1a10b9c3182b314a9f2
Gerrit-Change-Number: 13385
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 13:59:55 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190322/65ec74a2/attachment.html>


More information about the gerrit-log mailing list