Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket

osmith gerrit-no-reply at lists.osmocom.org
Fri Mar 22 10:08:49 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13347 )

Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h
File include/osmo-bts/pcuif_proto.h:

https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h@14
PS1, Line 14: 	
(stray tab)


https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2592
PS1, Line 2592: static int rslms_is_gprs_susp_req(struct msgb *msg)
> Can we please merge this function inside rslms_is_meas_rep and return GSM48_MT_* ? […]
Harald, what do you think?

Also would you prefer if I do the follow up changes to this patchset until it is ready, or do you want to do it (since it was your patch)?



-- 
To view, visit https://gerrit.osmocom.org/13347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f
Gerrit-Change-Number: 13347
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Mar 2019 10:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190322/d36ec1d6/attachment.html>


More information about the gerrit-log mailing list