Change in osmo-msc[master]: libmsc/sgs_vty.c: don't print SGs socket error twice

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Mar 21 19:09:47 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13372


Change subject: libmsc/sgs_vty.c: don't print SGs socket error twice
......................................................................

libmsc/sgs_vty.c: don't print SGs socket error twice

Because sgs_server_open() already does this.

Change-Id: Ifea308645c7829691dbcf53e4f59841090119006
---
M src/libmsc/sgs_vty.c
1 file changed, 2 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/72/13372/1

diff --git a/src/libmsc/sgs_vty.c b/src/libmsc/sgs_vty.c
index 8c94301..8ba5a79 100644
--- a/src/libmsc/sgs_vty.c
+++ b/src/libmsc/sgs_vty.c
@@ -57,10 +57,8 @@
 	osmo_stream_srv_link_set_addr(sgs->srv_link, sgs->cfg.local_addr);
 
 	rc = sgs_server_open(sgs);
-	if (rc < 0) {
-		vty_out(vty, "%% SGs socket cannot be opened: %s%s", strerror(errno), VTY_NEWLINE);
+	if (rc < 0)
 		return CMD_WARNING;
-	}
 
 	return CMD_SUCCESS;
 }
@@ -77,10 +75,8 @@
 	osmo_stream_srv_link_set_port(sgs->srv_link, sgs->cfg.local_port);
 
 	rc = sgs_server_open(sgs);
-	if (rc < 0) {
-		vty_out(vty, "%% SGs socket cannot be opened: %s%s", strerror(errno), VTY_NEWLINE);
+	if (rc < 0)
 		return CMD_WARNING;
-	}
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/13372
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifea308645c7829691dbcf53e4f59841090119006
Gerrit-Change-Number: 13372
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190321/c1729263/attachment.html>


More information about the gerrit-log mailing list