Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Mar 21 17:35:17 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13354 )

Change subject: trxcon: use helper to add l1ctl_info_dl
......................................................................


Patch Set 2:

> What would be advantage of using pointer instead of type?

1. It's safe against possible symbol renaming,
2. It's shorter ;)


-- 
To view, visit https://gerrit.osmocom.org/13354
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5b81f1fcd2984136e553a93735ea5456d2b3df
Gerrit-Change-Number: 13354
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Mar 2019 17:35:17 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190321/e6e9dc2e/attachment.html>


More information about the gerrit-log mailing list