Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Mar 21 15:05:45 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13354 )

Change subject: trxcon: use helper to add l1ctl_info_dl
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c
File src/host/trxcon/l1ctl.c:

https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@141
PS1, Line 141: put_dl_info
> Not a merge blocker, but I would prefer 'put_dl_info_hdr'.
Done


https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@143
PS1, Line 143: sizeof(struct l1ctl_info_dl);
> When I was writing this, I didn't know that we can do: […]
Interesting. What would be advantage of using pointer instead of type?


https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@148
PS1, Line 148: Init DL
> Do we really compose anything here? Let's just say 'init'.
Done



-- 
To view, visit https://gerrit.osmocom.org/13354
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5b81f1fcd2984136e553a93735ea5456d2b3df
Gerrit-Change-Number: 13354
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Mar 2019 15:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190321/8d0d08c4/attachment.htm>


More information about the gerrit-log mailing list