Change in osmocom-bb[master]: trxcon: use static helper to prepare FBSB

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Mar 21 13:09:34 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13355 )

Change subject: trxcon: use static helper to prepare FBSB
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/13355/1/src/host/trxcon/l1ctl.c
File src/host/trxcon/l1ctl.c:

https://gerrit.osmocom.org/#/c/13355/1/src/host/trxcon/l1ctl.c@304
PS1, Line 304: l1l->trx->band_arfcn
This is not an ARFCN itself, but ARFCN + band (and some other flags), so: band_arfcn &~ ARFCN_FLAG_MASK. Otherwise you would see garbage in some cases.


https://gerrit.osmocom.org/#/c/13355/1/src/host/trxcon/l1ctl.c@367
PS1, Line 367: LOGP
And please do this in a separate change, as this one states "trxcon: use static helper to prepare FBSB".


https://gerrit.osmocom.org/#/c/13355/1/src/host/trxcon/l1ctl.c@367
PS1, Line 367: LOGL_NOTICE
This message is more related to LOGL_INFO.



-- 
To view, visit https://gerrit.osmocom.org/13355
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43832d6a912a32ea5795ed0110981e0b714a7a61
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 13:09:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190321/4d502923/attachment.html>


More information about the gerrit-log mailing list