Change in osmo-ttcn3-hacks[master]: BTS: use PCU-related test cases as version string

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 20 22:02:39 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13305 )

Change subject: BTS: use PCU-related test cases as version string
......................................................................


Patch Set 3:

> > why are you copy-pasting a single line to dozens of functions?  I
 > don't understand why this patch cannot simply be a single-line diff
 > that changes only one line, replacing the static string with
 > testcasename() ?
 > 
 > Because there're both PCU-related and unrelated test cases. I'd
 > like to report testcasename() in place of PCU version only for the
 > former hence copy-paste. Am I missing something?

Well, then please either define a very simple non-parametric template and send that from every test case, or (more within our coding style) add a function and call it.  I don't think we want to copy+paste the identical line so many times all over. Thanks!


-- 
To view, visit https://gerrit.osmocom.org/13305
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ef9e46061ef116529bdea196050f914804615b3
Gerrit-Change-Number: 13305
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2019 22:02:39 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190320/fad13a47/attachment.html>


More information about the gerrit-log mailing list