Change in libosmocore[master]: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 20 10:56:55 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13332 )

Change subject: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4()
......................................................................

gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4()

When putting together a sockaddr_in, we must not only set the IP
address and port, but also set the address family to AF_INET.  And
while at it, let's zero-initialize the entire 'struct sockdadr_in'.

Change-Id: I1c8d8fe7f79a2ec737baa7800247269c3271983e
---
M src/gb/gprs_ns_sns.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/gb/gprs_ns_sns.c b/src/gb/gprs_ns_sns.c
index cbaa468..dd8d3a2 100644
--- a/src/gb/gprs_ns_sns.c
+++ b/src/gb/gprs_ns_sns.c
@@ -88,6 +88,8 @@
 	struct gprs_nsvc *nsvc;
 	struct sockaddr_in sin;
 	/* copy over. Both data structures use network byte order */
+	memset(&sin, 0, sizeof(sin));
+	sin.sin_family = AF_INET;
 	sin.sin_addr.s_addr = ip4->ip_addr;
 	sin.sin_port = ip4->udp_port;
 

-- 
To view, visit https://gerrit.osmocom.org/13332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c8d8fe7f79a2ec737baa7800247269c3271983e
Gerrit-Change-Number: 13332
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190320/91278cb5/attachment.html>


More information about the gerrit-log mailing list