Change in libosmocore[master]: signal.c: Fix osmo_signal_talloc_ctx_init()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 20 10:48:22 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13336


Change subject: signal.c: Fix osmo_signal_talloc_ctx_init()
......................................................................

signal.c: Fix osmo_signal_talloc_ctx_init()

This function is broken ever since it was added back in 2018 in commit
Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09

Rather than allocating from the user-supplied 'root_ctx', it is
allocating from the context that it's trying to create (which is
NULL at that time, rendering the entire operation more or less
a no-op.  For sure you will not see osmo_signal structures never in
any talloc report.

Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f
---
M src/signal.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/13336/1

diff --git a/src/signal.c b/src/signal.c
index 188876b..2302788 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -52,7 +52,7 @@
  *  \returns the new osmo_signal talloc context, e.g. for reporting
  */
 void *osmo_signal_talloc_ctx_init(void *root_ctx) {
-	tall_sigh_ctx = talloc_named_const(tall_sigh_ctx, 0, "osmo_signal");
+	tall_sigh_ctx = talloc_named_const(root_ctx, 0, "osmo_signal");
 	return tall_sigh_ctx;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/13336
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f
Gerrit-Change-Number: 13336
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190320/b64ec040/attachment.html>


More information about the gerrit-log mailing list