Change in libosmo-sccp[master]: add caller-owns-msgb variant osmo_sccp_user_sap_down2()

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Mar 19 15:47:58 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13277 )

Change subject: add caller-owns-msgb variant osmo_sccp_user_sap_down2()
......................................................................


Patch Set 1:

> what about the proposal with the 'volatile select dispatch talloc context'?

So far didn't consider placing msgb in that context, but that would also work.

> The '2' function suffix is normally used only in case we have a new API that deprecates older API.

I kind of feel like this is the better / newer version of the same, hence the 2, but it is not harmful to use the other one, so no deprecation -- but ok, can rename.


-- 
To view, visit https://gerrit.osmocom.org/13277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic818efa78b90f727e1a94c18b60d9a306644f340
Gerrit-Change-Number: 13277
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 19 Mar 2019 15:47:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/1ac011e7/attachment.html>


More information about the gerrit-log mailing list