Change in osmo-bsc[master]: osmo_bsc_bssap: check bssmap length field

dexter gerrit-no-reply at lists.osmocom.org
Tue Mar 19 14:49:49 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/13306 )

Change subject: osmo_bsc_bssap: check bssmap length field
......................................................................


Patch Set 1:

(3 comments)

> Uploaded patch set 2.

https://gerrit.osmocom.org/#/c/13306/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13306/1//COMMIT_MSG@7
PS1, Line 7: bssamp
> bssmap
Done


https://gerrit.osmocom.org/#/c/13306/1/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/#/c/13306/1/src/osmo-bsc/osmo_bsc_bssap.c@1100
PS1, Line 1100: 		     "BSSMAP message contains extranous data, expected %u bytes, got %u bytes, truncated\n",
> typo: extraneous? […]
Done


https://gerrit.osmocom.org/#/c/13306/1/src/osmo-bsc/osmo_bsc_bssap.c@1099
PS1, Line 1099: DMSC, LOGL_NOTICE,
              : 		     "BSSMAP message
> As usual, it makes sense to log some context along with the message. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/13306
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idef2e783d2377a2ad1f697ea4d26491a32b3e549
Gerrit-Change-Number: 13306
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 19 Mar 2019 14:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/10de9433/attachment.html>


More information about the gerrit-log mailing list