Change in libosmo-abis[master]: Add IPA keep-alive FSM implementation

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 13:53:07 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13196 )

Change subject: Add IPA keep-alive FSM implementation
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c
File src/input/ipa_keepalive.c:

https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c@126
PS2, Line 126: 					ifp->params.wait_for_resp, T_SEND_NEXT_PING);
> Are params correct or actually swapped? shouldn't be here ifp->params. […]
very nice catch, thanks!


https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c@181
PS2, Line 181: ipa_ka_idle
> If no events, why do we need this handler?
I didn't remember that we can have states without an action call-back.



-- 
To view, visit https://gerrit.osmocom.org/13196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2763da49a74de85046ac07d53592c89973314ca6
Gerrit-Change-Number: 13196
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 19 Mar 2019 13:53:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/68aed3fc/attachment.html>


More information about the gerrit-log mailing list