Change in osmo-bts[master]: pcu_sock: cast to long unsigned int before printing

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 13:07:22 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13267 )

Change subject: pcu_sock: cast to long unsigned int before printing
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/13267/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13267/3//COMMIT_MSG@7
PS3, Line 7: pcu_sock: cast to long unsigned int before printing
           : 
           : When using %lu and sizeof() for printing the compiler may throw a
           : warning. Lets prevent this by casting to long unsigned int.
the commit log message doens't match at all what the code change is doning now.  Please take care to make commit log messages match the code on subsequent edits. Thanks!



-- 
To view, visit https://gerrit.osmocom.org/13267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cb656537b1b73b9361a132801ab47ab7f8a709
Gerrit-Change-Number: 13267
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2019 13:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/7f876933/attachment.html>


More information about the gerrit-log mailing list