Change in osmo-bts[master]: oc2gbts_mgr: use osmo_init_logging2() instead of osmo_init_logging()

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 13:02:36 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13275 )

Change subject: oc2gbts_mgr: use osmo_init_logging2() instead of osmo_init_logging()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13275/1/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c
File src/osmo-bts-oc2g/misc/oc2gbts_mgr.c:

https://gerrit.osmocom.org/#/c/13275/1/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c@276
PS1, Line 276: tall_msgb_ctx = talloc_named_const(tall_mgr_ctx, 1, "msgb");
this should also be converted towards using msgb_talloc_ctx_init in a separate patch, forall code in this repository.


https://gerrit.osmocom.org/#/c/13275/1/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c@279
PS1, Line 279: tall_msgb_ctx
why tall_msgb_ctx and not tall_mgr_ctx?  Why would logging relate to message buffers?



-- 
To view, visit https://gerrit.osmocom.org/13275
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc80cd1f77f10a879d4536d788377f522dd853f
Gerrit-Change-Number: 13275
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2019 13:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/c6ec831e/attachment.html>


More information about the gerrit-log mailing list