Change in osmo-hlr[master]: hlr.c: properly terminate the process on SIGTERM

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 12:54:39 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13313 )

Change subject: hlr.c: properly terminate the process on SIGTERM
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13313/1/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13313/1/src/hlr.c@615
PS1, Line 615: 	case SIGTERM:
this fix is of course correct.  I recently read about signalfd() which might actually be a cleaner solution for all our signal handling.  Signals then get delivered via a special file descriptor which we can regiter in our libosmocore select logic and we don't have to worry about separate stacks, functions not safe to be called from interrupt handlers, adding "quit" variables like here, etc.



-- 
To view, visit https://gerrit.osmocom.org/13313
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4a48b95bbaed74ff5a03fb5797a44bdb1fcd3a
Gerrit-Change-Number: 13313
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2019 12:54:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/3a597b55/attachment.html>


More information about the gerrit-log mailing list