Change in libosmo-netif[master]: tests: AM_LDFLAGS = -noinstall for all tests

osmith gerrit-no-reply at lists.osmocom.org
Tue Mar 19 10:47:27 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13241 )

Change subject: tests: AM_LDFLAGS = -noinstall for all tests
......................................................................


Patch Set 4:

> similar patch for all unit tests in all repositories would be good. thanks

I've started with that, and realized that most other repositories use
noinst_PROGRAMS instead of check_PROGRAMS in test's Makefile.am files.

Reference for both:
https://www.gnu.org/software/automake/manual/automake.html#index-noinst_005f

I have checked, that noinst_PROGRAMS don't need AM_LDFLAGS = -noinstall.

The benefit of check_PROGRAMS is, that they only get built when "make check" gets executed. So in theory, using check_PROGRAMS together with -no-install seems to be the better choice.

However, replacing noinst_PROGRAMS with check_PROGRAMS in test's Makefile.am across all repositories would be quite some effort (most repositories have subdirs in tests, and even more Makefile.am files in there). So it does not seem like it is worth it to me. (Other opinions?)

I'm working on patches for the repositories with check_PROGRAMS to use -no-install now.


-- 
To view, visit https://gerrit.osmocom.org/13241
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d
Gerrit-Change-Number: 13241
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Alexander Huemer <alexander.huemer at xx.vu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: steve-m <steve at steve-m.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Tue, 19 Mar 2019 10:47:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/27f93b05/attachment.html>


More information about the gerrit-log mailing list