Change in osmo-msc[master]: a_iface_bssap: check bssamp length field

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 06:40:21 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13307 )

Change subject: a_iface_bssap: check bssamp length field
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13307/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13307/1//COMMIT_MSG@7
PS1, Line 7: bssamp
bssmap


https://gerrit.osmocom.org/#/c/13307/1/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/13307/1/src/libmsc/a_iface_bssap.c@721
PS1, Line 721: DBSSAP, LOGL_NOTICE,
             : 		     "BSSMAP message c
on the MSC side we cannot have log messages without any context.  The user will have no idea from which of his many BSCs this message is coming from.

The fact that other log messages in this file don't provide context is almost disturbing.  Let's make sure to fix those in a separat patch, too.



-- 
To view, visit https://gerrit.osmocom.org/13307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b89dd5a66ec83b03860b58b6b8eb58007f433a4
Gerrit-Change-Number: 13307
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 19 Mar 2019 06:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/8c0a397d/attachment.html>


More information about the gerrit-log mailing list