Change in osmo-bsc[master]: osmo_bsc_bssap: check bssamp length field

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 06:38:48 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13306 )

Change subject: osmo_bsc_bssap: check bssamp length field
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13306/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13306/1//COMMIT_MSG@7
PS1, Line 7: bssamp
bssmap


https://gerrit.osmocom.org/#/c/13306/1/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/#/c/13306/1/src/osmo-bsc/osmo_bsc_bssap.c@1099
PS1, Line 1099: DMSC, LOGL_NOTICE,
              : 		     "BSSMAP message
As usual, it makes sense to log some context along with the message.  Like which MSC has sent the message.  Yes, currently we (again) onlysupport one MSC in osmo-bsc, but it used to be different and it will again be different.  But as the other messages in this file don't appear to log context, we can accept the patch as-is.



-- 
To view, visit https://gerrit.osmocom.org/13306
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idef2e783d2377a2ad1f697ea4d26491a32b3e549
Gerrit-Change-Number: 13306
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 19 Mar 2019 06:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/f2854650/attachment.html>


More information about the gerrit-log mailing list