Change in osmo-bts[master]: Constify pcu_rx_*() parameters

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Mar 18 16:28:33 UTC 2019


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13298 )

Change subject: Constify pcu_rx_*() parameters
......................................................................

Constify pcu_rx_*() parameters

Use const for data parameter where appropriate.

Change-Id: Ia228c001ca07cfde61b540bec6257b62aec93517
---
M include/osmo-bts/l1sap.h
M src/common/l1sap.c
M src/common/pcu_sock.c
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  dexter: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h
index 3cf0ea5..70b4564 100644
--- a/include/osmo-bts/l1sap.h
+++ b/include/osmo-bts/l1sap.h
@@ -71,7 +71,7 @@
 
 /* pcu (socket interface) sends us a data request primitive */
 int l1sap_pdch_req(struct gsm_bts_trx_ts *ts, int is_ptcch, uint32_t fn,
-	uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len);
+	uint16_t arfcn, uint8_t block_nr, const uint8_t *data, uint8_t len);
 
 /* call-back function for incoming RTP */
 void l1sap_rtp_rx_cb(struct osmo_rtp_socket *rs, const uint8_t *rtp_pl,
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index dba08df..a1b0464 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1388,7 +1388,7 @@
 
 /* pcu (socket interface) sends us a data request primitive */
 int l1sap_pdch_req(struct gsm_bts_trx_ts *ts, int is_ptcch, uint32_t fn,
-	uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len)
+	uint16_t arfcn, uint8_t block_nr, const uint8_t *data, uint8_t len)
 {
 	struct msgb *msg;
 	struct osmo_phsap_prim *l1sap;
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 60e0f7a..2c7028e 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -466,7 +466,7 @@
 }
 
 static int pcu_rx_data_req(struct gsm_bts *bts, uint8_t msg_type,
-	struct gsm_pcu_if_data *data_req)
+	const struct gsm_pcu_if_data *data_req)
 {
 	uint8_t is_ptcch;
 	struct gsm_bts_trx *trx;
@@ -538,7 +538,7 @@
 }
 
 static int pcu_rx_pag_req(struct gsm_bts *bts, uint8_t msg_type,
-	struct gsm_pcu_if_pag_req *pag_req)
+	const struct gsm_pcu_if_pag_req *pag_req)
 {
 	int rc = 0;
 
@@ -598,7 +598,7 @@
 }
 
 static int pcu_rx_act_req(struct gsm_bts *bts,
-	struct gsm_pcu_if_act_req *act_req)
+	const struct gsm_pcu_if_act_req *act_req)
 {
 	struct gsm_bts_trx *trx;
 	struct gsm_lchan *lchan;

-- 
To view, visit https://gerrit.osmocom.org/13298
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia228c001ca07cfde61b540bec6257b62aec93517
Gerrit-Change-Number: 13298
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190318/32e5bcd5/attachment.html>


More information about the gerrit-log mailing list