Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available
gerrit-no-reply at lists.osmocom.org
Mon Mar 18 15:16:53 UTC 2019
Max has posted comments on this change. ( https://gerrit.osmocom.org/13253 )
Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available
Patch Set 5:
The tcpdump might be installed into non-standard location as well but we don't take that into account. How common is to have tcpdump and dumpcap in different directories?
PS4, Line 5: DUMPCAP=/usr/bin/dumpcap
> Mine is in /usr/local/bin/dumpcap. […]
Yes, we have to use absolute path because of setcap.
I'm somewhat reluctant to make it more complex by checking for unusual path - after all the goal is to make it work with the most common setup, not to support every distro imaginable.
PS4, Line 30: /sbin/setcap
> (might not be installed on all distributions there, I would have checked with "command")
Well if it's not installed than this check would simply fail and we're back to tcpdump.
PS4, Line 37: el
> How about telling the user why dumpcap is not used? […]
PS4, Line 35: DUMPER="$(ps -q "$(cat "$PIDFILE")" -o comm=)"
> Consider replacing `` with $(). […]
To view, visit https://gerrit.osmocom.org/13253
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Mon, 18 Mar 2019 15:16:53 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log