Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

osmith gerrit-no-reply at lists.osmocom.org
Mon Mar 18 14:28:38 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13301 )

Change subject: Add scripts/osmocom-list-commits.sh
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh
File scripts/osmocom-list-commits.sh:

https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh@51
PS1, Line 51: 
> Would be nice to make header printing optional to facilitate output parsing by shell scripts.
Made it optional with the current patch:

 NO_HEADER=1 ./osmocom-list-commits.sh


https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh@62
PS1, Line 62: 	head_commit="$(get_head_commit "$repo")"
> Is '=' actually required? It doesn't add human readability and seems like an unnecessary obstacle wh […]
The output format was based on an existing Makefile, that's why the '=' is there. But I don't think there's much benefit in keeping it, and you have a good point there. I've removed it.



-- 
To view, visit https://gerrit.osmocom.org/13301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da
Gerrit-Change-Number: 13301
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2019 14:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190318/27d0166c/attachment.html>


More information about the gerrit-log mailing list