Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

Max gerrit-no-reply at lists.osmocom.org
Mon Mar 18 13:58:48 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 )

Change subject: Add scripts/osmocom-list-commits.sh
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh
File scripts/osmocom-list-commits.sh:

https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh@62
PS1, Line 62: 		"=" \
Is '=' actually required? It doesn't add human readability and seems like an unnecessary obstacle when parsing from shell script.



-- 
To view, visit https://gerrit.osmocom.org/13301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da
Gerrit-Change-Number: 13301
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2019 13:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190318/39e15fe9/attachment.html>


More information about the gerrit-log mailing list