Change in libosmo-sccp[master]: add osmo_sccp_addr_cmp(), osmo_sccp_addr_ri_cmp()

Max gerrit-no-reply at lists.osmocom.org
Mon Mar 18 11:47:33 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13118 )

Change subject: add osmo_sccp_addr_cmp(), osmo_sccp_addr_ri_cmp()
......................................................................


Patch Set 2:

(1 comment)

Do you plan to use osmo_sccp_gt_cmp() or it can be made into static function and not part of the API?

https://gerrit.osmocom.org/#/c/13118/2/include/osmocom/sigtran/sccp_sap.h
File include/osmocom/sigtran/sccp_sap.h:

https://gerrit.osmocom.org/#/c/13118/2/include/osmocom/sigtran/sccp_sap.h@281
PS2, Line 281: int osmo_sccp_addr_cmp(const struct osmo_sccp_addr *a, const struct osmo_sccp_addr *b, uint32_t presence_criteria);
You've added 3 functions but only test 2 of them explicitly.



-- 
To view, visit https://gerrit.osmocom.org/13118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e2add7bbfae651c04e230d62e37cebeb91b0f5
Gerrit-Change-Number: 13118
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2019 11:47:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190318/75819934/attachment.html>


More information about the gerrit-log mailing list