Change in osmo-bts[master]: oml: make oml_tx_failure_event_rep() public

dexter gerrit-no-reply at lists.osmocom.org
Mon Mar 18 10:38:40 UTC 2019


dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13264 )

Change subject: oml: make oml_tx_failure_event_rep() public
......................................................................

oml: make oml_tx_failure_event_rep() public

The static function oml_tx_failure_event_rep() is a lot easier to use
than the currently implemented signal scheme. Lets make it public so
that we can quickly generate failure event reports.

Change-Id: I9c4601840a06119f35cfe4da453fff3b293fe615
Related: OS#3823
---
M include/osmo-bts/oml.h
M src/common/oml.c
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  Max: Looks good to me, but someone else must approve



diff --git a/include/osmo-bts/oml.h b/include/osmo-bts/oml.h
index 4dca2f8..a87d438 100644
--- a/include/osmo-bts/oml.h
+++ b/include/osmo-bts/oml.h
@@ -47,4 +47,7 @@
 /* Transmit failure event report */
 void oml_fail_rep(uint16_t cause_value, const char *fmt, ...);
 
+int oml_tx_failure_event_rep(const struct gsm_abis_mo *mo, uint16_t cause_value,
+			     const char *fmt, ...);
+
 #endif // _OML_H */
diff --git a/src/common/oml.c b/src/common/oml.c
index b04caf6..ac388d1 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -67,8 +67,8 @@
 }
 
 /* 3GPP TS 12.21 § 8.8.2 */
-static int oml_tx_failure_event_rep(const struct gsm_abis_mo *mo, uint16_t cause_value,
-				    const char *fmt, ...)
+int oml_tx_failure_event_rep(const struct gsm_abis_mo *mo, uint16_t cause_value,
+			     const char *fmt, ...)
 {
 	struct msgb *nmsg;
 	va_list ap;

-- 
To view, visit https://gerrit.osmocom.org/13264
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c4601840a06119f35cfe4da453fff3b293fe615
Gerrit-Change-Number: 13264
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190318/e50c8240/attachment.html>


More information about the gerrit-log mailing list