Change in libosmo-sccp[master]: add osmo_sccp_inst_unused_conn_id()

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Mar 15 17:24:25 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13278 )

Change subject: add osmo_sccp_inst_unused_conn_id()
......................................................................


Patch Set 1: Code-Review-1

This API, like I think I described quite verbosely, breaks the idea of a SAP.  The idea of a SAP is that there's no shared state between the provider and the user of the SAP, and that any communication between provider and user happens by means of asynchronous primitives.

Also, as I equally explained, we should neither expose nor document (in the commitlog, ...) that osmo_sccp currently simply uses the connection identifier (local significance on the SAP) as SCCP local reference on the wire.  That's a hack, and nobody should ever rely on it, or make that assumption.

Also, as we have seen in the related discussion, this is introducing bugs as the SCCP local reference is scoped to the SCCP user, while the "connection id" like the SAP is scoped to the SCCP instance.


-- 
To view, visit https://gerrit.osmocom.org/13278
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1b4897f4143b97bf90bfd8d0ae5d50bbd2e1dd
Gerrit-Change-Number: 13278
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 15 Mar 2019 17:24:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190315/4879fe1b/attachment.html>


More information about the gerrit-log mailing list