Change in osmo-bts[master]: oml: Use oml_tx_failure_event_rep() instead of signals to SS_FAIL

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Mar 15 17:17:47 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13269 )

Change subject: oml: Use oml_tx_failure_event_rep() instead of signals to SS_FAIL
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/13269/1/src/common/pcu_sock.c
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/#/c/13269/1/src/common/pcu_sock.c@581
PS1, Line 581: bts->mo
this should be bts->gprs.cell.mo


https://gerrit.osmocom.org/#/c/13269/1/src/common/pcu_sock.c@590
PS1, Line 590: 		oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_EXT_ALARM, txt->text);
this should be bts->gprs.cell.mo


https://gerrit.osmocom.org/#/c/13269/1/src/common/pcu_sock.c@717
PS1, Line 717: 	oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_PCU_VERS,
this should be bts->gprs.cell.mo



-- 
To view, visit https://gerrit.osmocom.org/13269
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fce1273a19cc14f37ff6fc7582b2945c7e7c47
Gerrit-Change-Number: 13269
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 15 Mar 2019 17:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190315/2284acfa/attachment.html>


More information about the gerrit-log mailing list