Change in osmo-bts[master]: oml: use oml_tx_failure_event_rep() instead of oml_fail_rep()

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13268 )

Change subject: oml: use oml_tx_failure_event_rep() instead of oml_fail_rep()
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Regarding the MO: trx->mo is the "Radio carrier" managed object.  This should only be used for errors that relate to the radio carrier, which I don't any of the lines relate to.

https://gerrit.osmocom.org/#/c/13268/1/src/common/bts.c
File src/common/bts.c:

https://gerrit.osmocom.org/#/c/13268/1/src/common/bts.c@313
PS1, Line 313: 		oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MAJ_RSL_FAIL,
trx->bb_transc.mo


https://gerrit.osmocom.org/#/c/13268/1/src/common/l1sap.c
File src/common/l1sap.c:

https://gerrit.osmocom.org/#/c/13268/1/src/common/l1sap.c@1367
PS1, Line 1367: trx->mo
trx->bb_transc.mo


https://gerrit.osmocom.org/#/c/13268/1/src/common/main.c
File src/common/main.c:

https://gerrit.osmocom.org/#/c/13268/1/src/common/main.c@196
PS1, Line 196: oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_CRIT_PROC_STOP,
             : 					 "BTS: signal %d (%s) received", signal,
             : 					 strsignal(signal));
this is actually wrong.  A SIGUSR1/2 is not a terminal signal, we only use it to get an intermediate talloc report without leaving the process.  So I think there should be a separate patch which removes this oml_fail_rep() completely.


https://gerrit.osmocom.org/#/c/13268/1/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/13268/1/src/common/rsl.c@469
PS1, Line 469: &trx->mo
paging queue is per BTS level, so it should be trx->bts->mo



-- 
To view, visit https://gerrit.osmocom.org/13268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83c4fa9ebd519299fd54b37b5d95d6d7c1da24f6
Gerrit-Change-Number: 13268
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 15 Mar 2019 17:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190315/ed1c8194/attachment.html>