Change in osmo-ttcn3-hacks[master]: msc: for mo and mt call, interleave MGCP and Assignment

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 15 15:15:57 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13191 )

Change subject: msc: for mo and mt call, interleave MGCP and Assignment
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/13191/2/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/13191/2/msc/BSC_ConnectionHandler.ttcn@533
PS2, Line 533: 		}
I think this style is full on inconsistent with all other coding style everywhere else. I'm only doing this because you guys made me do it, and hating it.


https://gerrit.osmocom.org/#/c/13191/2/msc/BSC_ConnectionHandler.ttcn@703
PS2, Line 703: 		}
I mean just look at this one. That is what happens with this nonsense indenting. Illogical, hard to read, flow broken. But there you have it.



-- 
To view, visit https://gerrit.osmocom.org/13191
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06af1e347601949f4ddb19f963daa400766d9e7
Gerrit-Change-Number: 13191
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 15:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190315/6af1251b/attachment.html>


More information about the gerrit-log mailing list