Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 14 20:44:55 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13253 )

Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available
......................................................................


Patch Set 1:

I really like the idea and I'm surprised we didn't do this sooner.  However, the fact that dumpcap is installed doesn't mean that a) it's setuid-root, or b) the current user has the right group/permission

On Debian systems, for example, it's part of the package configuration that is performed during package installation.

I think for this to work properly we'd need some way to test if capturing actually worked or if it was rejected before taking a decision for dumpcap.


-- 
To view, visit https://gerrit.osmocom.org/13253
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77df04d51a469c924cf727f0596cc33565909746
Gerrit-Change-Number: 13253
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 14 Mar 2019 20:44:55 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190314/c4c84c90/attachment.html>


More information about the gerrit-log mailing list