Change in osmo-ggsn[master]: Don't return error on normal shutdown

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 14 15:37:49 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13249 )

Change subject: Don't return error on normal shutdown
......................................................................

Don't return error on normal shutdown

Previously we've always returned error code from main() even in case of
regular expected shutdown. Let's not confuse it with actual error
shutdown and return 0 by default.

Change-Id: I7fe0d3e052953d5b87ce65649d88d83476fee3c0
---
M ggsn/ggsn.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  tnt: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index 39695b9..dd723e9 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -1158,5 +1158,5 @@
 	llist_for_each_entry(ggsn, &g_ggsn_list, list)
 		ggsn_stop(ggsn);
 
-	return 1;
+	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/13249
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fe0d3e052953d5b87ce65649d88d83476fee3c0
Gerrit-Change-Number: 13249
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190314/3654c076/attachment.html>


More information about the gerrit-log mailing list