Change in libosmo-sccp[master]: Fix output of route destination in 'show ss7 instance <0-15> route'

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 13 21:22:44 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13233 )

Change subject: Fix output of route destination in 'show ss7 instance <0-15> route'
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13233/1/src/osmo_ss7.c
File src/osmo_ss7.c:

https://gerrit.osmocom.org/#/c/13233/1/src/osmo_ss7.c@852
PS1, Line 852: 
> Those look rather generic? Maybe make it part of libosmocore bits. […]
yes, but it's a very stupid/inefficient implementation, and it's only five lines of code.  I'd rather keep it here.



-- 
To view, visit https://gerrit.osmocom.org/13233
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4fdbad953d40f222beb470a082eed8c20991ef
Gerrit-Change-Number: 13233
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Mar 2019 21:22:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/c2076d3f/attachment.html>


More information about the gerrit-log mailing list