This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@40 PS1, Line 40: char traffic_ip[INET_ADDRSTRLEN]; > Everywhere else in the code we use INET_ADDRSTRLEN. So I'd rather keep it consistent. […] Fine. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@91 PS1, Line 91: osmo_timer_schedule(&scd->timer, 0, 0); > Because at this point in the code, I'm in the callback of a state machine which isn't in the right s […] Can you at least document that in the code then? Otherwise people may attempt to simplify it. Add some "FIXME" or whatever. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@99 PS1, Line 99: } rtp_addr; > Why wouldn't it be ? […] Fine thanks, I had a look at sockaddr_storage to understand it better :) -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt at 246tNt.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2019 20:26:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/b24775c0/attachment.htm>