Change in osmo-pcu[master]: MCS: remove unused function

Max gerrit-no-reply at lists.osmocom.org
Wed Mar 13 19:15:17 UTC 2019


Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13239 )

Change subject: MCS: remove unused function
......................................................................

MCS: remove unused function

Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b
---
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
2 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index bcbb893..c0955d3 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -317,11 +317,6 @@
 	return mcs_info[m_scheme].family == mcs_info[o.m_scheme].family;
 }
 
-bool GprsCodingScheme::isCombinable(GprsCodingScheme o) const
-{
-	return numDataBlocks() == o.numDataBlocks();
-}
-
 void GprsCodingScheme::decToSingleBlock(bool *needStuffing)
 {
 	switch (m_scheme) {
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index d97df08..80f8502 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -67,7 +67,6 @@
 	bool isCompatible(Mode mode) const;
 	bool isCompatible(GprsCodingScheme o) const;
 	bool isFamilyCompatible(GprsCodingScheme o) const;
-	bool isCombinable(GprsCodingScheme o) const;
 
 	void inc(Mode mode);
 	void dec(Mode mode);

-- 
To view, visit https://gerrit.osmocom.org/13239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b
Gerrit-Change-Number: 13239
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/283aa42d/attachment.html>


More information about the gerrit-log mailing list