Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Mar 13 18:33:05 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13163 )

Change subject: MCS: move Mode enum outside of class definition
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h
File src/coding_scheme.h:

https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h@53
PS4, Line 53: enum Mode {
GprsMode? Mode is just too generic.


https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h@59
PS4, Line 59: const char *mode_name(enum Mode val);
same


https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.c
File src/coding_scheme.c:

https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.c@92
PS4, Line 92: const char *mode_name(enum Mode val) {
same



-- 
To view, visit https://gerrit.osmocom.org/13163
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3baaac7f1ca3f5b88917a23c1679d63847455f47
Gerrit-Change-Number: 13163
Gerrit-PatchSet: 4
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 18:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/a3cbd816/attachment.html>


More information about the gerrit-log mailing list