Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

Max gerrit-no-reply at lists.osmocom.org
Wed Mar 13 18:25:20 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13242 )

Change subject: libmsc: Allow different channel types to be requested as silent calls
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c
File src/libmsc/silent_call.c:

https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@107
PS1, Line 107: 				gsm0808_speech_codec_from_chan_type(&scl.codec[i], scd->ct.perm_spch[i]);
Would it make sense to re-use enc_speech_codec_list() from a_iface.c in here?


https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@187
PS1, Line 187: 	struct gsm0808_channel_type *ct,
ct is not changed in this function - why not make it const similar to traffic_dst_ip?



-- 
To view, visit https://gerrit.osmocom.org/13242
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602
Gerrit-Change-Number: 13242
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Mar 2019 18:25:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/1c9c6a1a/attachment.html>


More information about the gerrit-log mailing list