Change in osmo-msc[master]: vlr_subscr: use osmo_use_count

Max gerrit-no-reply at lists.osmocom.org
Tue Mar 12 15:04:13 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13136 )

Change subject: vlr_subscr: use osmo_use_count
......................................................................


Patch Set 2:

(1 comment)

Not sure what's the status of libosmocore patch, but you can split this one into 2 patches: 1) update #define of macro wrappers with extra parameters 2) actually adding use_count bits and using extra parameters.

That way patch will become significantly smaller (and hence easier to review) and the 1st part can be merged right away without waiting for libosmocore part.

https://gerrit.osmocom.org/#/c/13136/2/include/osmocom/msc/vlr.h
File include/osmocom/msc/vlr.h:

https://gerrit.osmocom.org/#/c/13136/2/include/osmocom/msc/vlr.h@361
PS2, Line 361: #define vlr_subscr_find_by_tmsi(vlr, tmsi, USE) \
This change is pretty-much independent from use_count API?



-- 
To view, visit https://gerrit.osmocom.org/13136
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib06d030e8464abe415ff597d462ed40eeddef475
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Mar 2019 15:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190312/ef9ee6d6/attachment.html>


More information about the gerrit-log mailing list