Change in osmocom-bb[master]: trxcon/scheduler: clarify decoding of incomplete xCCH blocks

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Mar 12 13:16:33 UTC 2019


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13197 )

Change subject: trxcon/scheduler: clarify decoding of incomplete xCCH blocks
......................................................................

trxcon/scheduler: clarify decoding of incomplete xCCH blocks

Inspired by Sylvain's message at #osmocom.
Change-Id: I3f499837413e1dbd0ca62229dc9cb6f0f7475a42
---
M src/host/trxcon/sched_lchan_xcch.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  tnt: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c
index 71eb38d..2d2b1d9 100644
--- a/src/host/trxcon/sched_lchan_xcch.c
+++ b/src/host/trxcon/sched_lchan_xcch.c
@@ -92,6 +92,10 @@
 			(*first_fn) % ts->mf_layout->period,
 			ts->mf_layout->period,
 			lchan_desc->name);
+		/* NOTE: xCCH has an insane amount of redundancy for error
+		 * correction, so even just 2 valid bursts might be enough
+		 * to reconstruct some L2 frames. This is why we do not
+		 * abort here. */
 	}
 
 	/* Attempt to decode */

-- 
To view, visit https://gerrit.osmocom.org/13197
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f499837413e1dbd0ca62229dc9cb6f0f7475a42
Gerrit-Change-Number: 13197
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190312/effb9476/attachment.html>


More information about the gerrit-log mailing list