This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13212 ) Change subject: amr: make buffer in osmo_amr_bwe_to_oa() static ...................................................................... Patch Set 1: Code-Review-1 I see no overhead in allocating that buffer in the stack, since anyway it has to modify the stack to allocate other local variables. Furthermore, making it static means that memory is in use all the time even if AMR is not being used. -- To view, visit https://gerrit.osmocom.org/13212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ffbf3a4515e1c2385a0b6b2d5fe8e756056fb0d Gerrit-Change-Number: 13212 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 12 Mar 2019 12:11:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190312/4bcf2f59/attachment.htm>